Skip to content

fix(website): fix Hugo navbar base-url links#5

Merged
visomi-dev merged 4 commits into
developfrom
cursor/home-page-display-issues-50d8
Mar 18, 2026
Merged

fix(website): fix Hugo navbar base-url links#5
visomi-dev merged 4 commits into
developfrom
cursor/home-page-display-issues-50d8

Conversation

@visomi-dev

@visomi-dev visomi-dev commented Mar 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • switch the Hugo navbar internal links to language-aware URLs that respect the GitHub Pages base path
  • use the localized site home permalink for the logo/home links so /visomi.dev/ and /visomi.dev/es/ render correctly
  • improve the home hero title wrapping on mobile and make the hero resume CTA use the localized path helper

Testing

  • pnpm exec tailwindcss -i apps/website/assets/css/styles.css -o apps/website/static/css/styles.css --minify && pnpm dlx hugo-bin -s apps/website -d dist/apps/website --gc --minify --baseURL /visomi.dev/
  • verified generated HTML in apps/website/dist/apps/website/index.html and apps/website/dist/apps/website/es/index.html contains the expected /visomi.dev/... navbar and resume links
Open in Web Open in Cursor 

@cursor cursor Bot changed the title fix(ng-website): honor base urls in nav links fix(website): fix Hugo navbar base-url links Mar 18, 2026
@visomi-dev visomi-dev marked this pull request as ready for review March 18, 2026 16:30
@visomi-dev visomi-dev merged commit 275d73e into develop Mar 18, 2026
1 of 2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0da4940e59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

href="{{ "journey" | absURL }}"
class="transition-colors hover:text-black dark:hover:text-white {{ if in .Page.RelPermalink "/journey" }}text-black dark:text-white{{ end }}"
href="{{ "journey" | relLangURL }}"
class="transition-colors hover:text-black dark:hover:text-white {{ if eq .Section "journey" }}text-black dark:text-white{{ end }}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve active nav state for root regular pages

The new eq .Section ... checks stop highlighting the current page for the existing English routes defined by apps/website/content/journey.md:1-5, projects.md:1-5, and resume.md:1-5. Those files live at the content root and set url directly, so Hugo does not put them in a top-level section; on /journey/, /projects/, and /resume/ the corresponding navbar item will now stay inactive, whereas the previous in .Page.RelPermalink ... logic handled those pages correctly.

Useful? React with 👍 / 👎.

@visomi-dev visomi-dev deleted the cursor/home-page-display-issues-50d8 branch April 10, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants